This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
replace retval of ToDB with {}interface(nil)
#1044
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
[]byte(nil)
.current custom types can't be set to
NULL
.because some drivers (like lib/pq) don't consider that
[]byte(nil)
is NULL . whenToDB()
returnnil
, it is[]byte(nil)
.This PR checks return values from
ToDB()
, and when it is[]byte(nil)
translates those to
{}interface(nil)
. it is treated asNULL