Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use context timeout instead of http client timeout option #545 #922

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jeevatkm
Copy link
Member

  • add Request.SetTimeout method

closes #545

@jeevatkm jeevatkm added feature v3 For resty v3 labels Nov 26, 2024
@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Nov 26, 2024
@jeevatkm jeevatkm self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (f18ee43) to head (5025cda).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   98.79%   99.55%   +0.76%     
==========================================
  Files          15       15              
  Lines        3230     3369     +139     
==========================================
+ Hits         3191     3354     +163     
+ Misses         28       10      -18     
+ Partials       11        5       -6     
Flag Coverage Δ
unittests 99.55% <100.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 48a1a59 into main Nov 26, 2024
6 checks passed
@jeevatkm jeevatkm deleted the context-timeout branch November 26, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature v3 For resty v3
Development

Successfully merging this pull request may close these issues.

1 participant