fix(internal/host): Extract optimizes the return of the minimum index IP #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
demoManito
force-pushed
the
fix/extract-minium-ip
branch
2 times, most recently
from
8fb83b0
to
3ab2f14
Compare
demoManito
force-pushed
the
fix/extract-minium-ip
branch
from
3ab2f14
to
a0edbcc
Compare
demoManito
commented
Nov 18, 2024
| @@ -50,10 +50,12 @@ func Extract(hostPort string, lis net.Listener) (string, error) { | |||
| if err != nil { | |||
| return "", err | |||
| } | |||
| minIndex := int(^uint(0) >> 1) | |||
There was a problem hiding this comment.
This maximum value increases the understanding mind, this extra operation is not required here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Extractoptimizes the return of the minimum index IPWhich issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: