add test case

go-kod · Nov 20, 2024 · e35383f · e35383f
1 parent d63f1ab
commit e35383f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/internal/server/http_upstream_invoker.go b/internal/server/http_upstream_invoker.go
@@ -21,6 +21,7 @@ func (i *invoker) Invoke(ctx context.Context, rw http.ResponseWriter, r *http.Re
 	parser, err := protojson.NewRequestParser(r, pathNames, upstream.resovler)
 	if err != nil {
 		i.L(ctx).Error("parse request", "error", err)
+		rw.Write([]byte(err.Error()))
 		return
 	}
 

diff --git a/test/integration/http_grpc_test.go b/test/integration/http_grpc_test.go
@@ -1,6 +1,7 @@
 package integration
 
 import (
+	"bytes"
 	"context"
 	"net/http"
 	"net/http/httptest"
@@ -92,4 +93,32 @@ func TestHTTP2Grpc(t *testing.T) {
 			assert.Equal(t, `{"code":2,"message":"error","details":[]}`, rec.Body.String())
 		}, kod.WithFakes(kod.Fake[config.Config](mockConfig)), kod.WithOpenTelemetryDisabled())
 	})
+
+	t.Run("http body", func(t *testing.T) {
+		kod.RunTest(t, func(ctx context.Context, up server.Upstream) {
+			router := http.NewServeMux()
+			up.Register(ctx, router)
+			rec := httptest.NewRecorder()
+			req, _ := http.NewRequest(http.MethodGet, "/say/sam", bytes.NewBufferString("{\"name\":\"bob\"}"))
+			req.Header.Set("Content-Type", "application/json")
+
+			router.ServeHTTP(rec, req)
+			assert.Equal(t, http.StatusOK, rec.Code)
+			assert.Equal(t, `{"message":"Hello sam"}`, rec.Body.String())
+		}, kod.WithFakes(kod.Fake[config.Config](mockConfig)), kod.WithOpenTelemetryDisabled())
+	})
+
+	t.Run("invalid http body", func(t *testing.T) {
+		kod.RunTest(t, func(ctx context.Context, up server.Upstream) {
+			router := http.NewServeMux()
+			up.Register(ctx, router)
+			rec := httptest.NewRecorder()
+			req, _ := http.NewRequest(http.MethodGet, "/say/sam", bytes.NewBufferString("{invalid data}"))
+			req.Header.Set("Content-Type", "application/json")
+
+			router.ServeHTTP(rec, req)
+			assert.Equal(t, http.StatusOK, rec.Code)
+			assert.Equal(t, `invalid character 'i' looking for beginning of object key string`, rec.Body.String())
+		}, kod.WithFakes(kod.Fake[config.Config](mockConfig)), kod.WithOpenTelemetryDisabled())
+	})
 }