Merge pull request #25 from go-jet/develop

Merge develop to master.

.circleci/config.yml

@@ -94,7 +94,7 @@ jobs:
 
 
       - run: mkdir -p $TEST_RESULTS
-      - run: go test -v ./... -coverpkg=github.com/go-jet/jet/postgres/...,github.com/go-jet/jet/mysql/...,github.com/go-jet/jet/execution/...,github.com/go-jet/jet/generator/...,github.com/go-jet/jet/internal/... -coverprofile=cover.out 2>&1 | go-junit-report > $TEST_RESULTS/results.xml
+      - run: go test -v ./... -coverpkg=github.com/go-jet/jet/postgres/...,github.com/go-jet/jet/mysql/...,github.com/go-jet/jet/qrm/...,github.com/go-jet/jet/generator/...,github.com/go-jet/jet/internal/... -coverprofile=cover.out 2>&1 | go-junit-report > $TEST_RESULTS/results.xml
 
       - run:
           name: Upload code coverage

internal/jet/statement.go

@@ -15,10 +15,12 @@ type Statement interface {
 	DebugSql() (query string)
 
 	// Query executes statement over database connection db and stores row result in destination.
-	// Destination can be arbitrary structure
+	// Destination can be either pointer to struct or pointer to a slice.
+	// If destination is pointer to struct and query result set is empty, method returns qrm.ErrNoRows.
 	Query(db qrm.DB, destination interface{}) error
 	// QueryContext executes statement with a context over database connection db and stores row result in destination.
-	// Destination can be of arbitrary structure
+	// Destination can be either pointer to struct or pointer to a slice.
+	// If destination is pointer to struct and query result set is empty, method returns qrm.ErrNoRows.
 	QueryContext(context context.Context, db qrm.DB, destination interface{}) error
 
 	//Exec executes statement over db connection without returning any rows.

internal/utils/utils.go

@@ -113,6 +113,13 @@ func IsNil(v interface{}) bool {
 	return v == nil || (reflect.ValueOf(v).Kind() == reflect.Ptr && reflect.ValueOf(v).IsNil())
 }
 
+// MustBeTrue panics when condition is false
+func MustBeTrue(condition bool, errorStr string) {
+	if !condition {
+		panic(errorStr)
+	}
+}
+
 // MustBe panics with errorStr error, if v interface is not of reflect kind
 func MustBe(v interface{}, kind reflect.Kind, errorStr string) {
 	if reflect.TypeOf(v).Kind() != kind {
@@ -165,6 +172,7 @@ func ErrorCatch(err *error) {
 	}
 }
 
+// StringSliceContains checks if slice of strings contains a string
 func StringSliceContains(strings []string, contains string) bool {
 	for _, str := range strings {
 		if str == contains {

postgres/functions.go

@@ -69,7 +69,7 @@ var COUNT = jet.COUNT
 // EVERY is aggregate function. Returns true if all input values are true, otherwise false
 var EVERY = jet.EVERY
 
-// MAXf is aggregate function. Returns maximum value of expression across all input values
+// MAX is aggregate function. Returns maximum value of expression across all input values
 var MAX = jet.MAX
 
 // MAXf is aggregate function. Returns maximum value of float expression across all input values