Run JS in strict mode, vendorize jquery.are-you-sure #26742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
puni9869
reviewed
Aug 26, 2023
Comment on lines
+6
to
+10
|
|
||
| var settings = $.extend( | ||
| { | ||
| 'message' : 'You have unsaved changes!', | ||
| 'dirtyClass' : 'dirty', |
There was a problem hiding this comment.
There are hundrets of lint errors in that file. We could try fixing them at the risk of breaking it.
|
Maybe we should just use https://github.com/github/session-resume and get rid of ays altogether. |
|
This is too much of a hack, will follow up with something better. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial extract from #25940: Use BannerPlugin to inject a
'use strict';statement into all chunks, resulting in all JS running in strict mode.jquery.are-you-sureonly works in sloppy mode, so I removed the global vars it introduced and vendorized the result.Example output:
Some dependency chunks already have that strict mode statement, resulting in a double statement. This can not easily be avoided with BannerPlugin, but it does not really hurt either.