Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for ManageEngine CloudDNS #2365

Merged
merged 20 commits into from
Dec 20, 2024
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 29, 2024

  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
    make build
    rm -rf .lego
    
    MANAGEENGINE_CLIENT_ID="xxx" \
    MANAGEENGINE_CLIENT_SECRET="yyy" \
    ./dist/lego -m [email protected] --dns manageengine -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @dgarner-cg, can you run the command (with your domain, email, credentials, etc.)?

-> #2365 (comment)

Closes #1933

How to test this PR?
  1. You need Go
  2. Checkout the PR:
    git clone https://github.com/ldez/lego.git
    cd lego
    git checkout feat/manageengine
  3. Compile lego:
    • if you have make: make build
    • if you don't make make: go build -o dist/lego ./cmd/lego
  4. Run the following command with your information (email, domain, credentials):
    MANAGEENGINE_CLIENT_ID="xxx" \
    MANAGEENGINE_CLIENT_SECRET="yyy" \
    ./dist/lego -m [email protected] --dns manageengine -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment:
    rm -rf .lego

@ldez ldez changed the title Add DNS provider for Add DNS provider for ManageEngine CloudDNS Nov 29, 2024
@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@dgarner-cg

This comment was marked as outdated.

@ldez ldez marked this pull request as ready for review December 20, 2024 02:28
@dgarner-cg
Copy link

dgarner-cg commented Dec 20, 2024

Great, I'm primary support this weekend so depending on how busy we are, I'll be stuck in front of a computer, hopefully nothing going on, if so, maybe then; otherwise, the following week/weekend.
Or you can email me your preferred contact via the email in our chain with Manage Engine, which ever you prefer.

I did send something now, will do more shortly. :)

@ldez ldez force-pushed the feat/manageengine branch from ac94d25 to 8dac1fa Compare December 20, 2024 02:29
Copy link

@dgarner-cg dgarner-cg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have successfully allowed ACME verification through Manage Engine's CloudDNS provider.

@ldez ldez requested a review from dmke December 20, 2024 02:30
@dgarner-cg
Copy link

@ldez
Ohh, forgot .. in our excitement, forgot..
Are you going to submit a new PR to remove the verbose logging and whatnot added to debug API issue?

@ldez
Copy link
Member Author

ldez commented Dec 20, 2024

I have already removed the debug logs from this PR.

There is some debug information behind an env var.
I added the additional logs during the development of this PR to help understand the API.
Now, I understand the API (and even the API doc 😸)

Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 52e711e into go-acme:master Dec 20, 2024
7 checks passed
@ldez ldez deleted the feat/manageengine branch December 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for provider: ManageEngine CloudDNS
3 participants