Don't set -fobjc-runtime=gnustep-2.0 as a global flag #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmfrederik
changed the title
qmfrederik
force-pushed
the
fixes/test-runtime
branch
from
912a0c9
to
bfcb988
Compare
|
Interesting. This should be a last-version-wins flag in clang. |
davidchisnall
approved these changes
Dec 31, 2023
davidchisnall
force-pushed
the
fixes/test-runtime
branch
from
bfcb988
to
bbb23ff
Compare
|
Looks like FreeBSD CI is failing because the versions that we’re testing on are EOL. |
|
[ Updating the branch to pick up fixes to the CI scripts. ] |
The legacy tests will override this flag.
davidchisnall
force-pushed
the
fixes/test-runtime
branch
from
bbb23ff
to
b980655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling:
in
CMakeLists.txtwill add-fobjc-runtime=gnustep-2.0as a compile option for all builds. The legacy tests will attempt to targetgnustep-1.7by calling:which will result in the same flag being defined twice (
-fobjc-runtime=gnustep-2.0 -fobjc-runtime=gnustep-1.7). In my setup, that resulted in clang targeting the 2.0 runtime, making the legacy tests invalid.