Tests: Append CMAKE_BINARY_DIR to PATH on Windows #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
approved these changes
Dec 30, 2023
|
Looks fine, but can you check that this works in a fresh terminal session? There were some exciting problems with CMake not preserving environment variable changes. |
|
On Windows, yes, this works (I tried locally and CI also excercises that path). |
Avoids copying objc.dll to the tests directory.
davidchisnall
force-pushed
the
windows-tests
branch
from
225133b
to
f2fc903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids copying objc.dll to the tests directory.