Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper data type for operation #38

Closed
wants to merge 3 commits into from

Conversation

gosuto-inzasheru
Copy link

it looks like abi-to-sol is not able to handle the Operation type properly.

here an interface built using foundry's cast interface, which does handle this type well

@gosuto-inzasheru
Copy link
Author

this issue is actually present in a lot of the interfaces, eg:

Screenshot 2024-05-31 at 11 36 23

@gosuto-inzasheru
Copy link
Author

updated all interfaces using cast interface scripts/abi/*** or straight from onchain deployments found here: https://github.com/safe-global/safe-deployments

@gosuto-inzasheru
Copy link
Author

this still doesnt fix the issue completely, there is still a downcast to uint8 taking place in foundry's cast interface as well...

i am still investigating the possibility of adding this to foundry. for abi-to-sol it is clear adding this feature is not possible; see: gnidan/abi-to-sol#132

@gosuto-inzasheru
Copy link
Author

neither abi-to-sol nor foundry can solve this problem; there is no programmatic way of creating interfaces that preserve the enums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant