Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ongoing oracle reports #67

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Remove ongoing oracle reports #67

merged 2 commits into from
Aug 6, 2019

Conversation

cag
Copy link
Contributor

@cag cag commented Aug 6, 2019

Affects #37

@cag cag merged commit 3bdc303 into master Aug 6, 2019
@cag cag deleted the remove-ongoing-oracle-reports branch August 6, 2019 22:49
@cag
Copy link
Contributor Author

cag commented Aug 7, 2019

@xavierlepretre For context, that change was implemented in #53. Those changes also included a change to the interface.

Yeah, it's a little less efficient than straight assembly because the arr[i] notation does bounds checking. There are some scenarios when the optimizer might be able to catch that this is unnecessary, but in general, without something like native iterator support or way to hint to the compiler that bounds checks should be skipped in the language, this would be hard to optimize away on the bytecode level.

Anyway, this is way more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants