Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing the table DB name to the enum-generation steps #99

Merged
merged 3 commits into from
Jul 26, 2018

Conversation

wuleninja
Copy link
Contributor

Solves #98

[mysql]

This changes allows to use the table name while generating file names or struct
names (in Go) for enums, which may help avoid name collisions (2 tables might
have 2 different enums but with the same column name).

Also: updated the dependencies with dep ensure.

This changes allows to use the table name while generating file names or struct
names (in Go) for enums, which may help avoid name collisions (2 tables might
have 2 different enums but with the same column name).

Also: updated the dependencies with dep ensure.
@natefinch
Copy link
Member

Can you back out the changes to the vendor directory? I don't want 33,000 lines of changes with this very tiny fix :) We can update the vendor directory separately :)

This changes allows to use the table name while generating file names or struct
names (in Go) for enums, which may help avoid name collisions (2 tables might
have 2 different enums but with the same column name).

Also: updated the dependencies with dep ensure.
@wuleninja
Copy link
Contributor Author

This should be better now (if the tests pass)

@natefinch natefinch merged commit 6d61ec9 into gnormal:master Jul 26, 2018
@natefinch
Copy link
Member

Thanks!

@wuleninja
Copy link
Contributor Author

Thanks to you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants