Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap web-ui README.md #127

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

shandysulen
Copy link
Contributor

Provide project-specific guidance in packages/web-ui/README.md to run web-ui locally.

Copy link
Owner

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for putting these instructions in the README!

Note that my CI build here requires adding every PR to the CHANGELOG. You mind doing that and then I'll merge this?

You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).

To learn React, check out the [React documentation](https://reactjs.org/).
`packages/abi-to-sol` hasn't been built. Go to `packages/abi-to-sol` and run `yarn prepare`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm kind of annoying that yarn doesn't automatically build everything in the repo root. Nonetheless, good to have these instructions here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG updated!

Agreed, I would think that running yarn in monorepo root would still trigger lifecycle scripts, like prepare, in individual packages. There's probably a nice solution out there -- we can update the README once we find it.

@gnidan gnidan merged commit 055a4a6 into gnidan:develop Jan 15, 2024
5 checks passed
@gnidan
Copy link
Owner

gnidan commented Jan 15, 2024

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants