Htmx army search #48
Merged
Htmx army search #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryaustin
commented
Oct 6, 2023
ryaustin
commented
- working htmx response for army-number-search
- load image from static
- install django-htmx - add into requirements.in - add into settings - add script cdn into base to make available project wide.
- handle post event
|
@gm3dmo Hi Dave, have you had an issue with the coverage failing in the past? |
|
no i dont think coverage had failed previously. |
|
Hmm, okay. Review the code. Maybe you want to rebuild this for your own experience. Htmx is pretty simple and just works so I needed to take a step back and see what I was missing. Turns out it was just going back to a simple <input> tag on the submit since we were posting to the army-search-url.
You will also notice that for the response, we target #query-response id which is the correct way to target using the id parameter. Also, a bit of bootstrap class pt-4 for padding top 4. You can play with all of this to get the final desired look and feel.
Thanks,
Ryan
…On Oct 6, 2023 at 2:18 PM -0400, David Morris ***@***.***>, wrote:
no i dont think coverage had failed previously.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.