feat: scale inner and outer gaps by monitor DPI #756
Conversation
| Err(_) => 1_f32, | ||
| }, | ||
| }; | ||
| self.0.borrow().inner_gap.clone() * scale |
There was a problem hiding this comment.
like in the Zebar PR, think we should only be scaling pixels here
would suggest adding a new field:
#[derive(Clone, Debug, Deserialize, Serialize)]
#[serde(rename_all(serialize = "camelCase"))]
pub struct GapsConfig {
/// Whether to scale the gaps with the DPI of the monitor.
#[serde(default = "default_bool::<true>")]
pub scale_with_dpi: bool,
// sample-config.yaml:
// gaps:
// # Whether to scale the gaps with the DPI of the monitor.
// scale_with_dpi: truethat way, we can make it more explicit that this gets scaled, since all other px values in the config deal with physical pixels.
would then have to change TilingSizeGetters::inner_gap, TilingSizeGetters::set_inner_gap, Workspace::set_outer_gap to instead get/set the GapsConfig struct.
to deal with only scaling px values and not %, maybe we could add something like LengthValue::to_px_scaled(&self, total_px: i32, scale_factor: f32)?
There was a problem hiding this comment.
Sounds good.
|
Will merge as is and add the |
lars-berger
changed the title
|
Ok, thank you. |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I was trying to make my zebar config work with multiple monitors that have different display scaling factors.
Related discussion: glzr-io/zebar#72
This PR suggests a possible fix by scaling
outer_gapandinner_gapby the display scale.Let me know if I should change something.