Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[123] update dependencies for data serving service #142

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/data-service-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: "16.x"
node-version: "22.3.0"
- name: Build and test
run: |
npm ci
Expand Down
2 changes: 1 addition & 1 deletion data-serving/data-service/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
},
extends: [
'plugin:@typescript-eslint/recommended', // Uses the recommended rules from the @typescript-eslint/eslint-plugin
'prettier/@typescript-eslint', // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
// 'prettier/@typescript-eslint', // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier
'plugin:prettier/recommended', // Enables eslint-plugin-prettier and eslint-config-prettier. This will display prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
],
globals: {
Expand Down
4 changes: 2 additions & 2 deletions data-serving/data-service/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Docker file for data service.
# Follows multi-staged build where "dev" can be used for development
# and "prod" follows security best-practices and uses a trimmed down image.
FROM node:16.18.0 as dev
FROM node:22.3.0 as dev

# Create app directory
WORKDIR /usr/src/app/data-serving/data-service
Expand Down Expand Up @@ -35,7 +35,7 @@ EXPOSE 3000
CMD [ "npm", "start" ]

# Multi-staged build, we don't need a full node image to run the app.
FROM node:16.18.0-alpine as prod
FROM node:22.3.0-alpine as prod

# No need to run as root.
USER node
Expand Down
Loading
Loading