Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[75] bulk add button did not work #120

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

stanislaw-zakrzewski
Copy link
Collaborator

Solves: #75

Changes:

  • Junior Curator is now able to bulk upload cases
  • Cases bulk uploaded by Senior Curator will be marked as verified
  • Case revision was being created multiple times for bulk upload and delete of given upload, now this error does not crash the app, but still the solution is not ideal (ticket for better solution has been created: Plan a strategy towards case revisioning #119)

@stanislaw-zakrzewski stanislaw-zakrzewski added this to the Bug resolving milestone Apr 3, 2024
@stanislaw-zakrzewski stanislaw-zakrzewski self-assigned this Apr 3, 2024
@stanislaw-zakrzewski stanislaw-zakrzewski linked an issue Apr 3, 2024 that may be closed by this pull request
Comment on lines 256 to 257
console.log('Failed to insert some case revisions');
console.log(err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use logger instead of console.log

Copy link
Contributor

@jim-sheldon jim-sheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one fix, otherwise looks good!

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 64.92%. Comparing base (b4208af) to head (9985787).
Report is 4 commits behind head on main.

Files Patch % Lines
...rving/data-service/src/controllers/preprocessor.ts 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   58.56%   64.92%   +6.35%     
==========================================
  Files         114      150      +36     
  Lines        3596     4895    +1299     
  Branches     1177     1515     +338     
==========================================
+ Hits         2106     3178    +1072     
- Misses       1490     1717     +227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stanislaw-zakrzewski stanislaw-zakrzewski merged commit 4a6b5c5 into main Apr 3, 2024
3 checks passed
@stanislaw-zakrzewski stanislaw-zakrzewski deleted the 75-bulk-add-button-did-not-work branch August 6, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk add button did not work
3 participants