Turn local-only threads into a one-way street #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o reply to a local-only post with a federated status (by accident)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an instance that runs a modified fork of Glitch.
Some clients don't automatically copy the eye emoji into a reply to a local-only message and users forget to set it manually. This leads to posts that are intended to be local-only being federated unintentionally.
We'd like to to turn local-only threads into a one-way streets:
Once a post has been made local-only, all replies to it should be local-only as well. This prevents leaking information.
If a user wants to make federated reply in a thread, they should reply to the latest federated post, which would not give away information about the existence of the local-only portions of a thread to users on other instances.