Increase the height of collapsed toots to 12 rem (192 px with default browser settings) #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r's default font settings) See glitch-soc#2483.
With increasing the collapsed toot height, the overlay gradient covered too much of the text making it unreadable. This adjusts it so that it covers only the lower half of the toot.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #2483, current collapsed toots barely display the first line of the text of the toot, which basically hides the toot almost entirely.
This PR increases the height of a collapsed toot to 12 rem (192 px if the user didn't change their browser's default font size), which is about the height of a "normal" 500-character toot on a 1920x1080 desktop with 100% zoom. This allows the reader to have an idea about the toot's contents to decide whether to unfold it or not.
It would be perhaps even better to have the height be set dynamically based on the maximum non-collapsed height configured in the app settings, but that is a task for a separate PR, as it would require more work.
This fixes the immediate readability problem with collapsed toots.