Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes up to 958a810553aac6b6cf21d9d107a47b6f68b2a401 #2656

Merged
merged 15 commits into from
Feb 29, 2024

Conversation

ClearlyClaire
Copy link

@ClearlyClaire ClearlyClaire commented Feb 29, 2024

Merge upstream changes up to 6dfe318

Ported changes

Merge upstream changes up to 958a810

Conflicts

  • app/javascript/packs/admin.jsx:
    This file was split between app/javascript/core/admin.js, app/javascript/pack/admin.jsx, and app/javascript/flavours/glitch/packs/admin.jsx.
    Ported upstream's change, splitting the new file to app/javascript/core/admin.ts, app/javascript/packs/admin.tsx, and app/javascript/flavours/glitch/packs/admin.tsx

github-actions bot and others added 14 commits February 29, 2024 09:38
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…e external link button

Port f24c62a to glitch-soc

Signed-off-by: Claire <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (25ac55e) to head (a04b384).
Report is 283 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
+ Coverage   84.87%   84.99%   +0.11%     
==========================================
  Files        1066     1069       +3     
  Lines       28921    28846      -75     
  Branches     4656     4657       +1     
==========================================
- Hits        24548    24517      -31     
+ Misses       3170     3131      -39     
+ Partials     1203     1198       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…oc/merge-upstream

Conflicts:
- `app/javascript/packs/admin.jsx`:
  This file was split between `app/javascript/core/admin.js`,
  `app/javascript/pack/admin.jsx`, and
  `app/javascript/flavours/glitch/packs/admin.jsx`.
  Ported upstream's change, splitting the new file to
  `app/javascript/core/admin.ts`, `app/javascript/packs/admin.tsx`,
  and `app/javascript/flavours/glitch/packs/admin.tsx`
@ClearlyClaire ClearlyClaire force-pushed the glitch-soc/merge-upstream branch from c75dbeb to f6654e0 Compare February 29, 2024 18:04
@ClearlyClaire ClearlyClaire changed the title Merge upstream changes up to TODO Merge upstream changes up to 958a810553aac6b6cf21d9d107a47b6f68b2a401 Feb 29, 2024
@ClearlyClaire ClearlyClaire marked this pull request as ready for review February 29, 2024 18:44
@ClearlyClaire ClearlyClaire merged commit 71f673b into glitch-soc:main Feb 29, 2024
31 checks passed
@Plastikmensch
Copy link

Note: 958a810 uses wrong types for onDomainBlockSeverityChange and OnChangeRegistrationMode (It should be HTMLSelectElement instead of HTMLInputElement)
It also uses wrong querySelectors for these.
This causes delegations to be skipped.

@ClearlyClaire
Copy link
Author

Thanks for pointing this out! Should be addressed by mastodon#29469 upstream

@Plastikmensch
Copy link

Can confirm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants