Allow posting media alongside polls #2524
Conversation
|
This pull request has merge conflicts that must be resolved before it can be merged. |
TheEssem
force-pushed
the
feature/poll-media
branch
from
8eab7f7 to
2f922a5
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
|
How does vanilla Mastodon behave when receiving such a post? When fetching a remote post with both, does it drop the media or the poll, or does it actually display both? |
|
Also, it would be great if this "feature"/removal of restrictions was exposed in /api/{v1,v2}/instance, so clients can know that this restriction is lifted. |
It renders both, with the poll above the media. Vanilla Mastodon supports rendering posts with both polls and media just fine; it just doesn't expose the functionality to do so.
Added. Might make it a config option too, if possible... |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2524 +/- ##
==========================================
+ Coverage 84.87% 84.97% +0.09%
==========================================
Files 1066 1068 +2
Lines 28921 28836 -85
Branches 4656 4657 +1
==========================================
- Hits 24548 24502 -46
+ Misses 3170 3135 -35
+ Partials 1203 1199 -4 ☔ View full report in Codecov by Sentry. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
TheEssem
force-pushed
the
feature/poll-media
branch
from
e3df69a to
c540156
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
TheEssem
force-pushed
the
feature/poll-media
branch
from
c540156 to
9bd21a7
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
TheEssem
force-pushed
the
feature/poll-media
branch
from
9bd21a7 to
c1520e3
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
Resolves #2486 and #2487. Just noticed those issues and decided to send this patch over; we've been running it for a few weeks with no issues as far as I can tell.