Fix mentions, hashtags and custom emojis being formatted with Markdown #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Tagadda
approved these changes
Oct 23, 2023
|
Would it be possible to also adjust this for custom emojis? |
Prevents usernames with underscores being formatted with underline. Signed-off-by: Plastikmensch <[email protected]>
Test that usernames with underscores get linked correctly Signed-off-by: Plastikmensch <[email protected]>
Prevents custom emojis and hashtags from being underlined and therefore broken. Signed-off-by: Plastikmensch <[email protected]>
Test for hashtags with underscores. Custom emojis are not tested for in this file and I'm not sure how best to add that. Signed-off-by: Plastikmensch <[email protected]>
Plastikmensch
force-pushed
the
fix-mentions-being-formatted-to-markdown
branch
from
5930fb7 to
d1acc6e
Compare
Plastikmensch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2432
Not the best solution, but the easiest I could think of not requiring a major refactor.
This will force escape underscores in mentions, hashtags and custom emojis.
This will still not link correctly when content type is html, but I consider that a separate issue.
(Mentions and hashtags don't get displayed as such, but still work)