Fix threaded mode continuesly editing same toot

[Plastikmensch]

Fixes #2429

Updated. See: #2430 (comment)

[Plastikmensch]

Rebased to fix a lint error which wasn't present when this PR was opened.

[ClearlyClaire]

I think I would just unset id, I'm not sure about the other behaviour, it seems pretty error-prone.

[Plastikmensch]

I think I would just unset id, I'm not sure about the other behaviour, it seems pretty error-prone.

Can do, but that would mean the thread would continue on the edited toot, which is likely unexpected.

[ClearlyClaire]

Hm… I suppose it should also clear in_reply_to. After all, the UI does not let you enable threaded mode when you're editing a post, it's only possible to run into this issue if you enable it first then edit a post.

[Plastikmensch]

Hm… I suppose it should also clear in_reply_to. After all, the UI does not let you enable threaded mode when you're editing a post, it's only possible to run into this issue if you enable it first then edit a post.

Wouldn't that break threaded mode?

[ClearlyClaire]

Hm… I suppose it should also clear in_reply_to. After all, the UI does not let you enable threaded mode when you're editing a post, it's only possible to run into this issue if you enable it first then edit a post.

Wouldn't that break threaded mode?

I mean, do that when id is set!

[Plastikmensch]

Hm… I suppose it should also clear in_reply_to. After all, the UI does not let you enable threaded mode when you're editing a post, it's only possible to run into this issue if you enable it first then edit a post.

Wouldn't that break threaded mode?

I mean, do that when id is set!

I'm not sure I'm understanding correctly, because id is set in COMPOSE_SET_STATUS and clearing in_reply_to there would break editing replies as they wouldn't be replies anymore.

[ClearlyClaire]

id is sent when you're editing a post. I mean, basically, when a post edit is submitted, clear the compose state instead of continuing in edit mode.

[Plastikmensch]

id is sent when you're editing a post. I mean, basically, when a post edit is submitted, clear the compose state instead of continuing in edit mode.

I'm still not sure what you mean, but what you're getting at is instead of continuing a thread after editing a toot in threaded mode, exit threaded mode?

[Plastikmensch]

Hmmh I think I get it now.
But that would mean a new thread is started after editing, as clearing the compose state explicitly doesn't exit threaded mode. The reason threaded mode exits when cancelling is because of the fallthrough.

That is why I propose saving the id of the last status in a thread, as all other solutions have undesirable side effects.
There can be an argument made whether to store the status object instead and restore the values of it after an edit instead of taking the values of the edited toot.
It pretty much comes down to what the expected behaviour should be.

[Plastikmensch]

Okay, made the following changes:

• threaded mode will now exit when editing a toot and the local-only option is set to the local-only attribute of the edited toot.
• Implemented fix for additional local-only emojis being added from Fix editing in threaded mode adding additional local-only emoji #2431

The second point is necessary because the local-only setting is now set to the toots local-only attribute, which also explains #2431 (comment)
I'm still for continuing threaded mode on the last tooted toot after an edit, but left that change out in favour of this issue getting fixed.
Note: manually removing the local-only emoji is no longer possible.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.