Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions gets rewritten as markdown #2432

Open
Tagadda opened this issue Oct 6, 2023 · 5 comments · May be fixed by #2433
Open

Mentions gets rewritten as markdown #2432

Tagadda opened this issue Oct 6, 2023 · 5 comments · May be fixed by #2433
Labels
bug

Comments

@Tagadda
Copy link

Tagadda commented Oct 6, 2023 •
edited
Loading

Steps to reproduce the problem

  1. Compose a toot mentioning a user with valid markdown as username: @[email protected]
  2. Send as markdown
    ...

Expected behaviour

The mention should not be processed as markdown

Actual behaviour

The mention gets rewritten as markdown

Detailed description

Example : https://biscuit.town/@tagada/111187829010716253

Mastodon instance

biscuit.town

Mastodon version

c04b08a

Technical details

If this is happening on your own Mastodon server, please fill out those:

  • Ruby version: v3.2.2
  • Node.js version: v18.12.1
@Tagadda Tagadda added the bug label Oct 6, 2023
@Plastikmensch Plastikmensch linked a pull request Oct 6, 2023 that will close this issue
Open
@kescherCode
Copy link

Yeah I ran into this again

@MagicLike
Copy link

same goes for custom emojis which should obviously not be parsed

@Plastikmensch
Copy link

same goes for custom emojis which should obviously not be parsed

I have never seen that happening with custom emojis.
Do you mind sharing some more info?
Like does it happen via web or third-party client, how the shortcode looks like and how you entered it etc.

@MagicLike
Copy link

Do you mind sharing some more info? Like does it happen via web or third-party client, how the shortcode looks like and how you entered it etc.

ofc, happens in the web as well as on third-party clients. For example with :neocat_comfy__w_:, where the underscores act as markdown parser triggers although it is encased in colons, which imo should not happen

How it is supposed to display:
grafik

How it actually displays:
grafik

@Plastikmensch
Copy link

Thank you! That helped a lot and is indeed the same issue.
This also applies to hashtags, though I don't remember ever seeing hashtags with underscores being used.

I'll try to update the PR as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mentions, hashtags and custom emojis being formatted with Markdown Plastikmensch/mastodon
4 participants
@kescherCode @Plastikmensch @Tagadda @MagicLike