Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phenix INI file support #256

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

melissalinkert
Copy link
Member

Similar to #213, just for Phenix v5.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good from a code review perspective. Passing onto @muhanadz for a round of functional testing

Copy link
Member

@muhanadz muhanadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the smaller .phenix file/plate example we've looked at in our development tests. Had a few warnings for missing OpenCV libraries. Ran the conversion with zlib compressions as cblosc dependencies were missing.

Conversion with bioformats2raw was successful. Converted with with raw2ometiff and imported into OMERO successfully. LGTM.

@sbesson sbesson merged commit 4229a4e into glencoesoftware:master Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants