Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of compile warnings #247

Closed
wants to merge 1 commit into from
Closed

Fix a couple of compile warnings #247

wants to merge 1 commit into from

Conversation

melissalinkert
Copy link
Member

Noticed while looking at #245. This is in the same spirit as ome/bioformats#4177 (and other PRs linked from there).

sbesson
sbesson approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@sbesson sbesson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the conversion of a few sample MIRAX files. Everything works as expected and the metadata is correctly populated under OME/METADATA.ome.xml

chris-allan
chris-allan reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@chris-allan chris-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semantics of new Double() are quite different than DataTools.parseDouble(). Was that also intended or desired here?

@melissalinkert
Copy link
Member Author

The semantics of new Double() are quite different than DataTools.parseDouble(). Was that also intended or desired here?

That was intentional, as using DataTools.parseDouble handles the possibility of a , decimal separator. I can switch it to Double.parseDouble if you prefer, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-allan chris-allan chris-allan left review comments

@sbesson sbesson sbesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melissalinkert @chris-allan @sbesson