gh-421: fix TestPyPI deployment #427
Open
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #421. Allows one to use `workflow_dispatch` to deploy the current setup to TestPyPI, this should allow us to test things work as expected. However, it still ensures that the `publish` workflow is still protected by the GitHub environment. This is achieved by changing the name of the job to `test-publish` when called with called by `workflow_dispatch`.
paddyroddy
added
bug
ntessore
reviewed
Nov 15, 2024
Saransh-cpp
approved these changes
Nov 15, 2024
Comment on lines
+50
to
+59
| name: >- | ||
| ${{ (github.event_name == 'release' && | ||
| github.event.action == 'published') && | ||
| 'publish' || | ||
| 'test-publish' }} | ||
| url: >- | ||
| ${{ (github.event_name == 'release' && | ||
| github.event.action == 'published') && | ||
| 'https://pypi.org/project/glass' || | ||
| 'https://test.pypi.org/project/glass' }} |
There was a problem hiding this comment.
TIL: this works as inline if-else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421. Allows one to use
workflow_dispatchto deploy the current setup to TestPyPI, this should allow us to test things work as expected.However, it still ensures that the
publishworkflow is still protected by the GitHub environment. This is achieved by changing the name of the job totest-publishwhen called with called byworkflow_dispatch.