Archunit rule to avoid guava #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Java 15: String.formatted * Java 21: SequencedCollection.getFirst() and .getLast() * Disable rule that adds a dependency to jakarta-annotation because the only javax.annotation we use are @NotNull and @nullable which are _not_ in that package * Guava: some changes not optimal; because it respects our use of a HashSet were in most cases, we didn't really care, except for the conciseness of Guava's factory method. Will change this further to use e.g Set.of(...)
…tations * Would be added by org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies via UpgradeToJava21 * See openrewrite/rewrite#4211
* ... where we don't really care about the specifics of which type of Set is instantiated
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.