-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace eslint-config-react-app #825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoseph
changed the title
Eslint replace eslint config react app
Replace eslint-config-react-app
Dec 11, 2024
gjoseph
force-pushed
the
eslint-replace-eslint-config-react-app
branch
2 times, most recently
from
December 12, 2024 23:50
9e70fa7
to
8cf49ea
Compare
…ions. Adapt eslint rules accordingly * npm -w tichu-web uninstall eslint-config-react-app * npm -w tichu-web install @typescript-eslint/eslint-plugin --save-dev * npm -w tichu-web install eslint-plugin-jsx-a11y@latest --save-dev * npm -w tichu-web install eslint-plugin-import@latest --save-dev
npx -w tichu-web eslint src/ --fix
… types, and addresses some linting errors * we currently don't use defaultValue anyway....
…or (`||`), as it is a safer operator @typescript-eslint/prefer-nullish-coalescing
* the previously used values were not even documented (node) * also align target with our other packages (es2023) while _their_ module/moduleResolution are still antiquated
gjoseph
force-pushed
the
eslint-replace-eslint-config-react-app
branch
from
December 12, 2024 23:51
8cf49ea
to
ae727b8
Compare
Open
gjoseph
force-pushed
the
eslint-replace-eslint-config-react-app
branch
from
December 13, 2024 04:57
59946f2
to
e27bb40
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.