Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint-config-react-app #825

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Conversation

gjoseph
Copy link
Owner

@gjoseph gjoseph commented Dec 11, 2024

No description provided.

@gjoseph gjoseph changed the title Eslint replace eslint config react app Replace eslint-config-react-app Dec 11, 2024
@gjoseph gjoseph force-pushed the eslint-replace-eslint-config-react-app branch 2 times, most recently from 9e70fa7 to 8cf49ea Compare December 12, 2024 23:50
Gregory Joseph added 8 commits December 13, 2024 10:50
…ions. Adapt eslint rules accordingly

* npm -w tichu-web uninstall eslint-config-react-app
* npm -w tichu-web install @typescript-eslint/eslint-plugin --save-dev
* npm -w tichu-web install eslint-plugin-jsx-a11y@latest --save-dev
* npm -w tichu-web install eslint-plugin-import@latest --save-dev
npx -w tichu-web eslint src/ --fix
… types, and addresses some linting errors

* we currently don't use defaultValue anyway....
…or (`||`), as it is a safer operator @typescript-eslint/prefer-nullish-coalescing
* the previously used values were not even documented (node)
* also align target with our other packages (es2023) while _their_ module/moduleResolution are still antiquated
@gjoseph gjoseph force-pushed the eslint-replace-eslint-config-react-app branch from 8cf49ea to ae727b8 Compare December 12, 2024 23:51
@gjoseph gjoseph mentioned this pull request Dec 13, 2024
@gjoseph gjoseph marked this pull request as ready for review December 13, 2024 04:48
@gjoseph gjoseph force-pushed the eslint-replace-eslint-config-react-app branch from 59946f2 to e27bb40 Compare December 13, 2024 04:57
@gjoseph gjoseph merged commit 35ffb07 into main Dec 13, 2024
10 checks passed
@gjoseph gjoseph deleted the eslint-replace-eslint-config-react-app branch December 13, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant