Switch to vite #805
Merged
Switch to vite #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need storybook update |
added 28 commits
December 9, 2024 20:35
* https://www.darraghoriordan.com/2021/05/16/migrating-from-create-react-app-to-vite#1-update-your-packagejson * Use vite-plugin-svgr 2.2.2 instead of 0.3.0 -- 2.3.0 brings compat with vite 4, so assuming this is for vite 3 npm -w tichu-web uninstall react-scripts npm -w tichu-web uninstall @craco/craco npm -w tichu-web install [email protected] [email protected] @vitejs/[email protected]
* remove %PUBLIC_URL% * remove other now-irrelevant cruft * Add script tag with the project entrypoint * https://www.darraghoriordan.com/2021/05/16/migrating-from-create-react-app-to-vite#6-update-the-content-of-indexhtml
* Remove CRA serviceWorker code * https://www.darraghoriordan.com/2021/05/16/migrating-from-create-react-app-to-vite#7-update-all-your-env-vars-if- you-use-them
npm -w tichu-web install -D vitest jsdom
npm uninstall @types/jest jest ts-test # only the fist was explicitely depended on here
* vite: from 3.2.2 to 6.0.1 * vite-plugin-svgr: from 2.2.2 to 4.3.0 * @vitejs/plugin-react from 2.2.0 to 4.3.4
... which is part of create-react-app, which blows. It's not maintained. But I couldn't find a good and maintained alternative that didn't involved hand-configuring a lot of eslint ... it brings too many warnings and even errors that I'm not sure how/why passed through before. Perhaps from the react 18 update recently. ... also brings back a ton of dependencies yuck npm -w tichu-web install --save-dev [email protected] [email protected] [email protected] [email protected] [email protected]
…but not sure that's useful/wanted, since a) we have tslint?? b) it goes and check the transpiled js
…app by @storybook/react-vite npm -w tichu-web uninstall --save-dev @storybook/react-webpack5 @storybook/preset-create-react-app npm -w tichu-web install --save-dev @storybook/react-vite
gjoseph
force-pushed
the
switch-to-vite
branch
from
2611332 to
2969539
Compare
done |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #574