Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ws to v8.17.1 - autoclosed #619

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 25, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ws 8.8.1 -> 8.17.1 age adoption passing confidence

Release Notes

websockets/ws (ws)

v8.17.1

Compare Source

Bug fixes

A request with a number of headers exceeding the[server.maxHeadersCount][server.maxHeadersCount]
threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');

const server = http.createServer();

const wss = new WebSocket.Server({ server });

server.listen(function () {
  const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
  const headers = {};
  let count = 0;

  for (let i = 0; i < chars.length; i++) {
    if (count === 2000) break;

    for (let j = 0; j < chars.length; j++) {
      const key = chars[i] + chars[j];
      headers[key] = 'x';

      if (++count === 2000) break;
    }
  }

  headers.Connection = 'Upgrade';
  headers.Upgrade = 'websocket';
  headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
  headers['Sec-WebSocket-Version'] = '13';

  const request = http.request({
    headers: headers,
    host: '127.0.0.1',
    port: server.address().port
  });

  request.end();
});

The vulnerability was reported by Ryan LaPointe in https://github.com/websockets/ws/issues/2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the
    [--max-http-header-size=size][--max-http-header-size=size] and/or the [maxHeaderSize][maxHeaderSize] options so
    that no more headers than the server.maxHeadersCount limit can be sent.
  2. Set server.maxHeadersCount to 0 so that no limit is applied.

v8.17.0

Compare Source

Features

  • The WebSocket constructor now accepts the createConnection option (#​2219).

Other notable changes

  • The default value of the allowSynchronousEvents option has been changed to
    true (#​2221).

This is a breaking change in a patch release. The assumption is that the option
is not widely used.

v8.16.0

Compare Source

Features

  • Added the autoPong option (01ba54e).

v8.15.1

Compare Source

Notable changes

  • The allowMultipleEventsPerMicrotask option has been renamed to
    allowSynchronousEvents (4ed7fe5).

This is a breaking change in a patch release that could have been avoided with
an alias, but the renamed option was added only 3 days ago, so hopefully it
hasn't already been widely used.

v8.15.0

Compare Source

Features

  • Added the allowMultipleEventsPerMicrotask option (93e3552).

v8.14.2

Compare Source

Bug fixes

  • Fixed an issue that allowed errors thrown by failed assertions to be
    swallowed when running tests (7f4e1a7).

v8.14.1

Compare Source

Bug fixes
  • Improved the reliability of two tests for CITGM (fd3c64c).

v8.14.0

Compare Source

Features

  • The WebSocket constructor now accepts HTTP(S) URLs (#​2162).
  • The socket argument of server.handleUpgrade() can now be a generic
    Duplex stream (#​2165).

Other notable changes

  • At most one event per microtask is now emitted (#​2160).

v8.13.0

Compare Source

Features

  • Added the finishRequest option to support late addition of headers (#​2123).

v8.12.1

Compare Source

Bug fixes

  • Added browser condition to package.json (#​2118).

v8.12.0

Compare Source

Features

  • Added support for utf-8-validate@6 (ff63bba).

Other notable changes

  • [buffer.isUtf8()][buffer.isUtf8()] is now used instead of utf-8-validate if available
    (42d79f6).

v8.11.0

Compare Source

Features

  • WebSocket.prototype.addEventListener() now supports an event listener
    specified as an object with a handleEvent() method. (9ab743a).

Bug fixes

  • WebSocket.prototype.addEventListener() now adds an event listener only if it
    is not already in the list of the event listeners for the specified event type
    (1cec17d).

v8.10.0

Compare Source

Features

  • Added an export for package.json (211d5d3).

v8.9.0

Compare Source

Features

  • Added the ability to connect to Windows named pipes (#​2079).

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/ws branch 6 times, most recently from 74f0353 to cec39f2 Compare October 2, 2022 12:36
@renovate renovate bot force-pushed the renovate/ws branch 4 times, most recently from 0ee5f14 to 2cd3ae0 Compare October 10, 2022 14:38
@renovate renovate bot force-pushed the renovate/ws branch 6 times, most recently from a69ef28 to bdac3e0 Compare October 20, 2022 01:06
@renovate renovate bot force-pushed the renovate/ws branch 3 times, most recently from 8698830 to 0534960 Compare October 24, 2022 22:30
@renovate renovate bot changed the title Update dependency ws to v8.9.0 Update dependency ws to v8.10.0 Oct 25, 2022
@renovate renovate bot force-pushed the renovate/ws branch 3 times, most recently from b915b74 to e3b6b30 Compare October 26, 2022 11:25
@renovate renovate bot changed the title Update dependency ws to v8.10.0 Update dependency ws to v8.9.0 Oct 26, 2022
@renovate renovate bot changed the title Update dependency ws to v8.9.0 Update dependency ws to v8.10.0 Oct 27, 2022
@renovate renovate bot changed the title Update dependency ws to v8.12.1 Update dependency ws to v8.13.0 Mar 12, 2023
@renovate renovate bot force-pushed the renovate/ws branch 4 times, most recently from d2632dd to c8e046c Compare March 18, 2023 03:02
@renovate renovate bot changed the title Update dependency ws to v8.13.0 Update dependency ws to v8.14.0 Sep 8, 2023
@renovate renovate bot force-pushed the renovate/ws branch 2 times, most recently from ae4ef82 to 659e3bd Compare September 10, 2023 17:03
@renovate renovate bot changed the title Update dependency ws to v8.14.0 Update dependency ws to v8.14.1 Sep 10, 2023
@renovate renovate bot changed the title Update dependency ws to v8.14.1 Update dependency ws to v8.14.2 Sep 21, 2023
@renovate renovate bot changed the title Update dependency ws to v8.14.2 Update dependency ws to v8.15.0 Dec 11, 2023
@renovate renovate bot changed the title Update dependency ws to v8.15.0 Update dependency ws to v8.15.1 Dec 14, 2023
@renovate renovate bot force-pushed the renovate/ws branch 2 times, most recently from 65e8e50 to 6e9c6d0 Compare December 28, 2023 18:28
@renovate renovate bot changed the title Update dependency ws to v8.15.1 Update dependency ws to v8.16.0 Dec 28, 2023
@renovate renovate bot changed the title Update dependency ws to v8.16.0 Update dependency ws to v8.17.0 Apr 30, 2024
@renovate renovate bot changed the title Update dependency ws to v8.17.0 Update dependency ws to v8.17.1 Jun 18, 2024
@renovate renovate bot changed the title Update dependency ws to v8.17.1 Update dependency ws to v8.17.1 - autoclosed Jun 19, 2024
@renovate renovate bot closed this Jun 19, 2024
@renovate renovate bot deleted the renovate/ws branch June 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants