Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename old TWITTER_CLIENT_ID(and SECRET) to new X_CLIENT_ID naming convention #430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

honzapatCZ
Copy link

What kind of change does this PR introduce?

Bug fix

Why was this change needed?

Inconsistency

Other information:

Took me quite a while to figure out why, the X integration wasn't working. These variables are nowhere documented, and as it seems also outdated.

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • I have read the CONTRIBUTING guide.
  • I checked that there were not similar issues or PRs already open for this.
  • This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

Copy link

vercel bot commented Nov 12, 2024

@honzapatCZ is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@bingmatch
Copy link

mods please approve this commit, much needed

@nevo-david
Copy link
Contributor

We can't do it as it is making a breaking change. Please do it like this:

      clientId: process.env.TWITTER_CLIENT_ID! || process.env.X_CLIENT_ID!,
      clientSecret: process.env.TWITTER_CLIENT_SECRET! || process.env.X_CLIENT_SECRET!

@honzapatCZ
Copy link
Author

Sure, done :)

@bingmatch
Copy link

@nevo-david please commit this

@bingmatch
Copy link

@nevo-david please approve this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants