add heroku 1-click deployment files #383
Conversation
|
@rohitdash08 is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @rohitdash08 , thanks for the PR, I can see you've put some work into this. I am worried about maintaining this going forward, as it duplicates another Dockerfile, another supervisord config, and similar. It also annoys me that ".deploy" is a weird name for a directory for Heroku!
|
|
Hi @jamesread, I have made the changes can you please have a look? |
| if [[ "$SKIP_CONFIG_CHECK" != "true" ]]; then | ||
| echo "Entrypoint: Copying /config/postiz.env into /app/.env" | ||
|
|
||
| cp -vf /app/supervisord_available_configs/caddy.conf /etc/supervisor.d/ |
There was a problem hiding this comment.
Removing these lines will break the existing docker containers.
| @@ -2,13 +2,33 @@ | |||
|
|
|||
| set -o xtrace | |||
|
|
|||
| export DATABSAE_URL=${DATABASE_URL:-$HEROKU_POSTGRESQL_DATABASE_URL} | |||
There was a problem hiding this comment.
Waiting for the database should be handled on the platform level.
| if [ ! -f /config/postiz.env ]; then | ||
| echo "Entrypoint: WARNING: No postiz.env file found in /config/postiz.env" | ||
| fi | ||
|
|
||
| ln -sf /app/supervisord_available_configs/frontend.conf /etc/supervisor.d/ |
| @@ -17,6 +37,12 @@ if [[ "$POSTIZ_APPS" -eq "" ]]; then | |||
| POSTIZ_APPS="frontend workers cron backend" | |||
| fi | |||
|
|
|||
| if [[$POSTIZ_APPS == *"workers"* ]]; then | |||
There was a problem hiding this comment.
These lines just look wrong.
|
|
||
| build: | ||
| docker: | ||
| web: ghcr.io/gitroomhq/postiz-app-enterprise:latest |
There was a problem hiding this comment.
You shouldn't use the enterprise containers.
| "description": "Secret key for JWT tokens", | ||
| "generator": "secret" | ||
| }, | ||
| "ADMIN_PASSWORD": { |
| "description": "REDIS_URL for Redis connection", | ||
| "required": true | ||
| }, | ||
| "APP_URL": { |
| @@ -64,6 +64,9 @@ jobs: | |||
| docker tag ghcr.io/gitroomhq/postiz-devcontainer-enterprise:${{ env.CONTAINERVER }} ghcr.io/gitroomhq/postiz-devcontainer-enterprise:latest | |||
| docker push ghcr.io/gitroomhq/postiz-devcontainer-enterprise:latest | |||
|
|
|||
| docker tag localhost/postiz ghcr.io/gitroomhq/postiz-app-enterprise:latest | |||
| docker push ghcr.io/gitroomhq/postiz-app-enterprise:latest | |||
There was a problem hiding this comment.
Please don't change the enterprise container workflows.
This PR fixes #341
What kind of change does this PR introduce?
This PR introduces a feature that adds a Heroku 1-click deployment option using Docker. It includes configuration files such as app.json, heroku.yml, Dockerfile, and scripts for seamless deployment on Heroku using containers.
Why was this change needed?
This change was needed to simplify the deployment process for Postiz users. By introducing a Heroku 1-click deployment option, users can deploy the platform faster without manually configuring.
Other information:
I just gave it a try as it was pending for a long time, someone else is assigned to it but he's away for so long,
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;