-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AB-0002]: google auth configuration simplified #262
base: main
Are you sure you want to change the base?
[AB-0002]: google auth configuration simplified #262
Conversation
@alexkucherenko is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
Yeah i would like to solve the issue :) |
Hey @OleksandrKucherenko , a lot of these changes generally look good, but you're mixing a bunch of stuff up into a single PR. Could you please cherry pick the various changes into new branches and submit a PR per logical change, please? |
let's merge the PR #260 and than I will rebase this branch and it will make commits/changes much cleaner. |
As discussed on Discord, you're going to rebase this PR. |
3a82fb9
to
28572a4
Compare
c852d50
to
43fa27e
Compare
43fa27e
to
b88b97c
Compare
This is generally looking OK, but can you drop out the changes on .env.example, and just leave the commits on the Google provider to keep the PR clean please? |
@OleksandrKucherenko ping? |
Sorry, busy weeks... preparations for black friday and holidays... So again what stops you to merge?
|
What kind of change does this PR introduce?
Why was this change needed?
Should be rebased and merged after this PR: #260