-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JetBrains] Migrate backend-plugin platform version for 2024.2
#19978
Conversation
- Update Platform Version of JetBrains Backend Plugin (EAP) to 242.18071-EAP-CANDIDATE-SNAPSHOT
This reverts commit 4574632.
2024.2
@@ -2,7 +2,7 @@ | |||
// Licensed under the GNU Affero General Public License (AGPL). | |||
// See License.AGPL.txt in the project root for license information. | |||
|
|||
rootProject.name = "jetbrains-backend-plugin" | |||
rootProject.name = "gitpod-remote" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change the name here because new platform plugin will treat it as build result name
@@ -1,5 +1,5 @@ | |||
distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-bin.zip | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required for new platform plugin (beta)
- - "bash" | ||
- "-c" | ||
- > | ||
echo java=21.0.3.fx-zulu > .sdkmanrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it requirement only for build time? at runtime any java version will work still with 2024.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, just asking that we don't need to change anything in our images, java 21 then is bundled together with IJ?
// Licensed under the GNU Affero General Public License (AGPL). | ||
// See License.AGPL.txt in the project root for license information. | ||
|
||
import io.gitlab.arturbosch.detekt.Detekt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to duplicate this file.
We can use build.gradle.kts for latest, and build.gradle-stable.kts.
If someone wants to change they can unload one from IJ and load another.
for building we can pass different with ./gradlew --build-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failed with this change 3cc4494
Searched error Build cache controller already set
that it may need --no-build-cache
, but after modification, build failed again (if we copy it into build.gradle.kts, it will work):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to revert that commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base on the reverting, keep different build.gradle-<version>.kts
is more useful for me: so that I could keep these two copies and use build.gradle.kts
to debug with launcher-dev-server.sh
This reverts commit 3cc4494.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes make sense to me, but someone should double test that we don't break stable especially
is it known and going to be fixed? |
It's not known, I need to ask JetBrains what happends (I see it found no BackendTerminalManager class in idea.log) As it's EAP versions, we could let it go and make terminal stuff another follow up issue |
@akosyakov for message above☝️ |
Description
Use new beta IntelliJ Platform Plugin which is required by JetBrains IDEs version
2024.2.*
Related Issue(s)
Fixes ENT-350, ENT-330
How to test
(nit) Port forwarding
Backend Status Details
page (click right top Gitpod icon) >Ports
tab, port8080
should display correct state and functions like open in browser should workDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold