Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nginx config example to cut-off ".git" #173

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xaionaro
Copy link

It's required to be able to clone with

git clone https://git.example.com/user/project

instead of

git clone https://git.example.com/user/project.git

as it already is on GitHub.

server {
listen *:80 default;
location / {
rewrite ^ https://git.example.com$request_uri? permanent;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document somewhere that people have to change this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my English skills, but I don't understand the question.

Did you mean "why people have to change that"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point you have hardcoded the url https://git.example.com people may not know that they have to change this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Can you show an example of the "documentation"? Should I just add a note in the first lines of this configuration file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axilleas Yeah thanks :)

@dosire
Copy link
Member

dosire commented Sep 10, 2015

Should this go into the normal GitLab?

@MiniDigger
Copy link

I think having both features (cut of .git and /public as default start page when not logged in) as toggles would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants