Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1651 - Adds an option to open a file on click in Search & Compare #3583

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EhabY
Copy link

@EhabY EhabY commented Sep 15, 2024

Description

Closes #1651. This PR adds an option in the GitLens settings to open the file when clicking on its entry in the Search & Compare instead of opening the diff view.

Since this issue was only for the Search & Compare, I only added this settings for this view. If there is need to add it to the other views then I can do that as well. Supersedes #2845 since that one seems to be stale now.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@EhabY EhabY changed the title Fixed #1651 - Adds an option to open a file on click in Search & Compare Fixes #1651 - Adds an option to open a file on click in Search & Compare Sep 22, 2024
@EhabY EhabY force-pushed the allow-opening-file-on-click branch from 48b5b7d to 0948fd6 Compare September 22, 2024 23:01
@eamodio eamodio self-requested a review September 27, 2024 21:01
@EhabY
Copy link
Author

EhabY commented Dec 8, 2024

@eamodio Merged main into this branch, ready for review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening file instead of diff
1 participant