Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies GitLab auth provider to use gk.dev (GLVSC-555) #3370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jul 1, 2024

Description

Checks for a local GitLab authentication and if it exists uses it.
Otherwise, it checks the GKDev for a GitLab integration to use it.
If GKDev is not connected it starts the GK authentication flow.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

src/constants.ts Outdated
@@ -876,8 +876,11 @@ export type SupportedAIModels =
| `openai:${AIModels<'openai'>}`
| 'vscode';

const supportedCloudIntegrationIds = ['github', 'jira'];
export type SupportedCloudIntegrationIds = HostingIntegrationId.GitHub | IssueIntegrationId.Jira;
const supportedCloudIntegrationIds = ['github', 'gitlab', 'jira'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the enums similar to the union type after it?

const supportedCloudIntegrationIds = [
	HostingIntegrationId.GitHub,
	HostingIntegrationId.GitLab,
	IssueIntegrationId.Jira,
];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sergeibbb sergeibbb force-pushed the feature/GLVSC-555-use-gkdev-gitlab branch from 68b1e2a to 5b5a3ad Compare July 2, 2024 10:38
@sergeibbb sergeibbb force-pushed the feature/GLVSC-555-use-gkdev-gitlab branch from 5b5a3ad to 526d8fc Compare July 2, 2024 12:45
Base automatically changed from GLVSC-554-use-gkdev-github to main July 3, 2024 15:10
@sergeibbb sergeibbb force-pushed the feature/GLVSC-555-use-gkdev-gitlab branch from 526d8fc to 69c4e24 Compare July 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants