feat: show read notifications #889
Conversation
setchy
changed the title
setchy
added
the
enhancement
|
With the improved Settings layout, I've kept this consistent and made this a new Notifications setting called
Example The feature is a little limited since we don't fetch more than the first page of notifications (per account). Later, this may change |
| @@ -23,11 +23,11 @@ describe('hooks/useNotifications.ts', () => { | |||
| ]; | |||
|
|
|||
| nock('https://api.github.com') | |||
| .get('/notifications?participating=false') | |||
| .get('/notifications?all=false&participating=false') | |||
There was a problem hiding this comment.
Needing to update the same string throughout is a code smell, FWIW :)
Haha yeah, they're starting to flow nicely. I remembered a use-case I need to test with this enhancement (ensure clicking mark as read correctly changes row state before the next scheduled fetch). Will confirm shortly |
|
If you're happy and you know it, merge conflict |
|
Moving back to |
|
Reopening a new PR (#1052) as I've reworked this |
closes #708
Add read / unread toggle in sidebar. Read notifications have a higher opacity and hide the mark as read button on hover-over.
Some GitHub API Limitations I've found:
unread/notificationsresponse to indicate if a notification is done or not done (ie: in the inbox)These have been documented in #890