Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: auto label prs #1347

Merged
merged 6 commits into from
Jul 9, 2024
Merged

build: auto label prs #1347

merged 6 commits into from
Jul 9, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jul 9, 2024 •
edited
Loading

Based on feedback from #1342 (comment) - thanks @afonsojramos 😄

@github-actions github-actions bot added the build Build, action or package manager changes label Jul 9, 2024
@setchy
Copy link
Member Author

setchy commented Jul 9, 2024

We could probably remove the Validate PR Title step from validator.yml and rely on the Semantic Pull Request check that this action creates.

Note: I haven't mapped these types to a label: chore, perf, revert, style

@setchy setchy added this to the Release 5.10.0 milestone Jul 9, 2024
afonsojramos
afonsojramos approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I haven't mapped these types to a label: chore, perf, revert, style

Is it okay for those PRs to not have a label? Is there a "misc" section for those cases in the release notes?

@setchy
Copy link
Member Author

setchy commented Jul 9, 2024

Note: I haven't mapped these types to a label: chore, perf, revert, style

Is it okay for those PRs to not have a label? Is there a "misc" section for those cases in the release notes?

We see so few of them that I was thinking we're just handle them ad-hoc

@setchy setchy merged commit 79d461c into main Jul 9, 2024
10 checks passed
@setchy setchy deleted the feat/auto-labeler branch July 9, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
build Build, action or package manager changes
Projects
None yet
Milestone
Release 5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos