-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support github enterprise api #225
base: main
Are you sure you want to change the base?
feat: support github enterprise api #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One import question. Nice break out of the auth content.
@@ -1,12 +1,15 @@ | |||
#!/usr/bin/env python | |||
""" Find stale repositories in a GitHub organization. """ | |||
from __future__ import annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jmeridth,
I've tried this because of this error on the pipeline:
https://github.com/github/stale-repos/actions/runs/11576316507/job/32229613440#step:5:38
It seems that it's not the best approach since it still fails. I haven't looked into the other repositories to check what might be the difference because the code between them is the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be time to drop support for python v3.9 like we have for our other actions.
Pull Request
Proposed Changes
This Pull request is based on the already merged github/evergreen#256 to give support to GitHub Enterprise login using a GitHub App also created on GitHub Enterprise
Code coverage
Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducing@jeffrey-luszcz
Reviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking