Refactor Sign/Verify functions into their own library. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit should have no change in existing behavior, but does the following: 1. Pulls the sign/verify commands into its own package that can be invoked directly instead of needing to go through main. 2. Refactors the certstore library (a dependency of the sign library) to separate out the OS-dependent libraries so that any platform can safely pull in the certstore Identity interface. Adds a register func so that this can be set dynamically in main. My hope is to use this to allow similar tools to reuse this to provide additional identities and optional verification behavior. Signed-off-by: Billy Lynch <[email protected]>
wlynch
added a commit
to wlynch/smimecosign
that referenced
this pull request
May 11, 2022
This forks the changes made in github/smimesign#108 into this repo. This was done because the replace directive was preventing go install from functioning properly. Once the upstream PR is merged, we can revert this change.
wlynch
added a commit
to wlynch/gitsign
that referenced
this pull request
May 12, 2022
This forks the changes made in github/smimesign#108 into this repo. This was done because the replace directive was preventing go install from functioning properly. Once the upstream PR is merged, we can revert this change.
wlynch
added a commit
to wlynch/gitsign
that referenced
this pull request
May 12, 2022
This forks the changes made in github/smimesign#108 into this repo. This was done because the replace directive was preventing go install from functioning properly. Once the upstream PR is merged, we can revert this change. Signed-off-by: Billy Lynch <[email protected]>
wlynch
added a commit
to sigstore/gitsign
that referenced
this pull request
May 12, 2022
This forks the changes made in github/smimesign#108 into this repo. This was done because the replace directive was preventing go install from functioning properly. Once the upstream PR is merged, we can revert this change. Signed-off-by: Billy Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit should have no change in existing behavior, but does the following:
Pulls the sign/verify commands into its own package that can be invoked directly
instead of needing to go through main.
Refactors the certstore library (a dependency of the sign library) to separate out
the OS-dependent libraries so that any platform can safely pull in the certstore
Identity interface. Adds a register func so that this can be set dynamically in
main.
My hope is to use this to allow similar tools to reuse this to provide additional
identities and optional verification behavior. (see sigstore/cosign#865 (comment) for an example!)
Signed-off-by: Billy Lynch [email protected]