Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create org-list-outside-collaborators-by-repo.graphql #742

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Create org-list-outside-collaborators-by-repo.graphql #742

merged 2 commits into from
Oct 23, 2024

Conversation

gennaropalma
Copy link
Contributor

No description provided.

sn2b
sn2b reviewed Oct 21, 2024
View reviewed changes
graphql/queries/org-list-outside-collaborators-by-repo.graphql Outdated
@@ -0,0 +1,25 @@
query( $cursor: String) {
organization(login: "another-boring-org") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to follow the naming convention here with "ORG_NAME" so it's clear that it's a variable that is supposed to be replaced

sn2b
sn2b reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@sn2b sn2b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the same variable names wherever possible, apart from that it looks great!

@sn2b sn2b merged commit fcd5900 into master Oct 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sn2b sn2b sn2b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gennaropalma @sn2b