Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRST TRY #3051

Conversation

pervertperson
Copy link

@pervertperson pervertperson commented Jul 23, 2023

#3043 github:gh-readonly-queue/main/pr-2985-d5e9427b8bc38fe0b720d434032321bae23b2397

  • Have you followed the contributing guidelines?
    l1- [ ] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

----- )

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

**Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested

information.**

Andreas Sünder and others added 30 commits February 26, 2023 16:54
Some sentences sounded weird, so I corrected them, along with some other typos & smaller improvements.
Update link href to one that doesn't 404
Fix typos and minor errors in German translation
Fix editorial inconsistencies or inaccuracies
Polish and fix translation of simple Chinese
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v7...v8)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…actions/stale-8

Bump actions/stale from 7 to 8
Update new GitHub create repository UI
Fix typo "有効的" -> "友好的" in Japanese
[korean translation] translate sentences more naturally and translate wise saying
#NO_C🍪🍪KIES
Same modification with github@3dd708f

"有効的" in Japanese means "effective" in English, while "友好的" means "friendly".

I guess the original translator of this article made this mistake because both of them are pronounced as "yūkō-teki".
igrep and others added 8 commits July 6, 2023 22:39
"モラル" in Japanese means "moral" in English (a katakana word pronounced similarly with "moral"), while "士気" means "morale".

It looks like that the original translator mistook "morale" for "moral".
Minor fixes for the Japanese translation of legal.md
Optimize the article according to the normal expression in Chinese.
@pervertperson pervertperson requested a review from a team as a code owner July 23, 2023 00:14
Copy link
Author

@pervertperson pervertperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramangudewar
Copy link

Merge pull request #3051 Add Fathom Analytics 📊

Copy link

@Amanparmar90 Amanparmar90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.