Add pagination support to GetIdpGroupId method #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results811 tests 811 ✅ 21s ⏱️ Results for commit a20fabd. |
|
|
Closing in favor of #1267, the changes of this branch were merged into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetIdpGroupIdmethod hasn't been using pagination to get all groups so far. This PR adds pagination support to theGetIdpGroupIdmethod by using the newGetAllAsyncoverload that accepts a result collection selector.The new overload was necessary because the List extrernal groups API is returning a Json object instead of an Array. With the new selector it'd be now possible to specify the desired field which is the result collection.
ThirdPartyNotices.txt(if applicable)