Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update both upload and download artifact dependencies #1268

Merged
merged 11 commits into from
Oct 7, 2024
Merged
13 changes: 7 additions & 6 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ jobs:
# This is used by the subsequent publish-test-results.yml
- name: Upload Unit Test Results
if: always() && matrix.runner-os == 'ubuntu-latest'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Unit Test Results
path: src/OctoshiftCLI.Tests/unit-tests.xml

# This is used by the subsequent publish-test-results.yml
- name: Upload Code Coverage Report
if: always() && matrix.runner-os == 'ubuntu-latest'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Code Coverage Report
path: code-coverage-results.md
Expand All @@ -85,7 +85,7 @@ jobs:
steps:
# This is used by the subsequent publish-test-results.yaml
- name: Upload Event File
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
SKIP_LINUX: "true"

- name: Upload Binaries
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binaries-${{ matrix.target-os }}
path: |
Expand Down Expand Up @@ -161,9 +161,10 @@ jobs:
uses: actions/setup-dotnet@v2
with:
global-json-file: global.json


- name: Download Binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: binaries-${{ matrix.runner-os }}
path: dist
Expand Down Expand Up @@ -260,7 +261,7 @@ jobs:
comment_mode: off

- name: Upload test logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: integration-test-logs-${{ matrix.source-vcs }}-${{ matrix.runner-os }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
SKIP_LINUX: "true"

- name: Upload Binaries
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binaries-${{ matrix.target-os }}
path: |
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
global-json-file: global.json

- name: Download Binaries
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: binaries-${{ matrix.runner-os }}
path: dist
Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
commit: ${{ env.PR_SHA }}

- name: Upload test logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: integration-test-logs-${{ matrix.source-vcs }}-${{ matrix.runner-os }}
Expand Down
Loading