Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically build and release the CLI for the linux-arm64 build target #1235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chtzvt
Copy link

@chtzvt chtzvt commented May 1, 2024

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Copy link

github-actions bot commented May 1, 2024

Unit Test Results

810 tests   810 ✅  22s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit a95b454.

♻️ This comment has been updated with latest results.

@chtzvt
Copy link
Author

chtzvt commented May 1, 2024

RE #1230 (comment) I've essentially made a carbon copy of Tim's commit for windows-x86, but will perform some additional testing in my fork.

@chtzvt
Copy link
Author

chtzvt commented May 1, 2024

Or perhaps not... For some reason, none of the workflows in my fork appear in the Actions tab of my fork!

Would love to dispatch the CI workflow and actually test the built linux-arm64 release.

image

@dylan-smith
Copy link
Collaborator

Or perhaps not... For some reason, none of the workflows in my fork appear in the Actions tab of my fork!

Would love to dispatch the CI workflow and actually test the built linux-arm64 release.

When I fork repos I get this in my fork:
image

@chtzvt
Copy link
Author

chtzvt commented Jun 26, 2024

@dylan-smith I was able to create a separate fork of this repository, merge this PR into it, and run a modified version of the CI workflow (which removed the E2E integration tests, as their success is required for the publish step to proceed but I cannot run them).

The modified CI workflow run produced working aarch64 builds for Linux in the publish step, which I was able to verify as executable on an ARM Linux VM:

Screenshot 2024-06-26 at 16 17 30

I've invited you as an outside collaborator to that repository if you'd like to access/inspect the built artifacts on your end.

@dylan-smith
Copy link
Collaborator

I no longer work on the gei eng team (I just lurk in the repo), so one of the engineers from that team will have to shepherd this PR in.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
bbs2gh 78% 73% 651
ado2gh 84% 78% 627
Octoshift 87% 76% 1272
gei 79% 70% 519
Summary 83% (6821 / 8172) 75% (1534 / 2044) 3069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants