Skip to content

Commit

Permalink
retry all test asserts (bbs only for now)
Browse files Browse the repository at this point in the history
  • Loading branch information
@dylan-smith
dylan-smith authored Sep 26, 2024
1 parent 7b43293 commit d79b1f6
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,14 @@ await retryPolicy.Retry(async () =>
await _targetHelper.RunBbsCliMigration(
$"generate-script --github-org {githubTargetOrg} --bbs-server-url {bbsServer} --bbs-project {bbsProjectKey}{archiveDownloadOptions}{archiveUploadOptions}", _tokens);

_targetHelper.AssertNoErrorInLogs(_startTime);
await new RetryPolicy(_logger).Retry(() => {
_targetHelper.AssertNoErrorInLogs(_startTime);
await _targetHelper.AssertGithubRepoExists(githubTargetOrg, repo1);
await _targetHelper.AssertGithubRepoExists(githubTargetOrg, repo2);
await _targetHelper.AssertGithubRepoInitialized(githubTargetOrg, repo1);
await _targetHelper.AssertGithubRepoInitialized(githubTargetOrg, repo2);
await _targetHelper.AssertGithubRepoExists(githubTargetOrg, repo1);

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 127 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.
await _targetHelper.AssertGithubRepoExists(githubTargetOrg, repo2);

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 128 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.
await _targetHelper.AssertGithubRepoInitialized(githubTargetOrg, repo1);

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 129 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.
await _targetHelper.AssertGithubRepoInitialized(githubTargetOrg, repo2);

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (macos-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (ubuntu-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoBasic) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Ghes) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Bbs) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, Github) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

Check failure on line 130 in src/OctoshiftCLI.IntegrationTests/BbsToGithub.cs

View workflow job for this annotation

GitHub Actions / e2e-test (windows-latest, AdoCsv) 

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.
});

// TODO: Assert migration logs are downloaded
}
Expand Down

0 comments on commit d79b1f6

Please sign in to comment.