Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show relative path examples, because filenames alone won't work #35386

Conversation

gregorywilliams
Copy link
Contributor

Why:

Show relative path examples, because just using filenames results in a 404 response.

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changed example workflow from just filename, main.yml, to a path relative to the repo, .github/workflows/main.yml, which matches the paths that the List and Get calls return.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 21, 2024
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/rest/data/fpt-2022-11-28/schema.json
  • src/rest/data/ghec-2022-11-28/schema.json
  • src/rest/data/ghes-3.10-2022-11-28/schema.json
  • src/rest/data/ghes-3.11-2022-11-28/schema.json
  • src/rest/data/ghes-3.12-2022-11-28/schema.json
  • src/rest/data/ghes-3.13-2022-11-28/schema.json
  • src/rest/data/ghes-3.14-2022-11-28/schema.json
  • src/rest/data/ghes-3.15-2022-11-28/schema.json

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@nguyenalex836
Copy link
Contributor

Howdy @gregorywilliams! 👋 Unfortunately our bot is correct - we aren't able to accept contributions to these files.

I'll file an issue to have this reviewed internally - thank you for the heads up on this! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants