Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Java: add SHA-224 and SHA-384 to list of secure crypto algorithms #18087

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Nov 24, 2024

Description

Adds SHA-224 and SHA-384 as secure algorithms so that the java/potentially-weak-cryptographic-algorithm query no longer flags these uses.

Adding SHA-224 and SHA-384 aligns Java with other languages.

Note that SHA-224 may be deprecated soon based on NIST's most recent draft revision of Transitioning the Use of Cryptographic Algorithms and Key Lengths, so let me know if I should not add it here.

This PR is based on #18084.

Pull Request checklist

All query authors

Internal query authors only

  • Changes are validated at scale (internal access required).

@jcogs33
Copy link
Contributor Author

jcogs33 commented Nov 25, 2024

DCA alerts look good. Adding SHA-384 as a secure algorithm removes 46 FP alerts from the OWASP benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants